Repository navigation
Separate Model Target implementation tests from the shared suite - #3756
Merged
adamtheturtle merged 1 commit intoOct 13, 2026
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared Model Target Web API directory still contains tests that instantiate
MockVWS, invoke the Flask target manager directly, or inspect a core dataset object. Move those tests into the implementation-owned test areas before packaging the shared contract suite.requests_mock, and its target-manager deletion case to the existing Flask Model Target module.MockVWSprocessing/failure behavior into the existing Requests Model Target module.requests_mock/test_model_target.py. Every destination is covered by an existing CI directory partition.The shared Model Target directory no longer imports
MockVWS, Flask internals, or the concrete dataset model. Part of #3738 and #3737.Validation:
git diff --checkpasses.This moves tests within existing CI partitions. Source code, workflows, dependencies, real-service opt-ins, and coverage gates remain unchanged. Hosted full-suite verification will run on this PR.