Repository navigation
Supply Model Target credentials through backend fixtures - #3755
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model Target authentication helpers and shared tests still select credentials by concrete backend identity. Supply credentials through typed backend fixtures instead, and let token requests accept only the supplied credentials and service URL.
The adapter now owns ordinary, mock-only, and signed-request credential fixtures. The existing signing opt-in condition and skip reason move with them, so an opted-out real signing test skips before loading credentials. Shared Model Target assertions and request helpers no longer import or select
VuforiaBackend; implementation setup remains in the directory fixtures. Remove the redundant token wrapper and the outdated plugin-order comment.Part of #3738 and #3737, independent of the VuMark URL changes in #3754.
Validation:
git diff --checkpasses.No source package, dependency, workflow, or coverage gate changes. Full-suite hosted validation will run on this PR.