Repository navigation
Select imported signing certificates by hash - #2686
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When another signing certificate has a matching name, selecting by a name prefix can fail as ambiguous or choose the first listed identity. Use the certificate-import action’s
identitiesoutput, require exactly one identity of the appropriate type, and sign using its SHA-1 hash. The action is pinned to the v7.1.0 commit.Includes the v7.1.0 dependency update proposed in #2674 and uses the selected hash for all three macOS binaries.
Validation:
git diff --checkpassed.Credentialed signing and notarization were not run locally.