Repository navigation
Test the moved-to-v2 notice - #2270
Merged
Merged
Conversation
Patches the WorkOS emulator to store organization metadata, as the real Create and Update Organization endpoints do.
RhysSullivan
added this pull request to stack #2268
October 12, 2026 00:45
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 6443ec2 | Oct 12 2026, 12:49 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 6443ec2 | Commit Preview URL Branch Preview URL |
Oct 12 2026, 12:48 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
October 12, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests for #2269.
apps/cloud/src/auth/v2-moved.test.tscovers the metadata parsing: a moved org, unrelated keys, offset normalization, missing keys, malformed slugs and timestamps. It covers the live WorkOS read: moved, not moved, and a WorkOS failure. It also covers thev2-importanswer: a moved org is not offered the import and its eligibility is not read; an unmoved org gets the import link; malformed or unreadable metadata counts as not moved; and with no v2 host nothing is read.apps/cloud/src/web/v2-moved-snooze.test.tscovers the 7-day and 30-day snooze, that each org is snoozed separately, unreadable stored values, and storage that is missing or throws.cloud/v2-moved-notice.test.tsseeds WorkOS organization metadata through the emulator's Update Organization route and covers three cases:The WorkOS emulator does not store organization metadata, so the existing local emulate patch gains Create and Update Organization
metadatasupport. Updates are partial,nulldeletes a key, and{}clears all keys, as WorkOS documents. The same support is being added upstream in emulate. This patch can be dropped once that is published.The analytics events are not asserted in e2e because the e2e stack mounts no PostHog client.
Verification
bun run test(867 passed)cloud/v2-moved-notice.test.ts(3 passed) andcloud/v2-import-link.test.ts(4 passed)