Repository navigation
Test the v2 import sidebar link - #2267
Merged
Merged
Conversation
RhysSullivan
added this pull request to stack #2268
October 11, 2026 21:55
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 9190d4d | Commit Preview URL Branch Preview URL |
Oct 11 2026, 10:55 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 9190d4d | Oct 11 2026, 10:56 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
v1-sidebar-v2-import-tests
branch
from
October 11, 2026 22:53
d215728 to
9fc9b8a
Compare
RhysSullivan
force-pushed
the
v1-sidebar-v2-import-tests
branch
from
October 11, 2026 22:54
9fc9b8a to
9190d4d
Compare
RhysSullivan
marked this pull request as ready for review
October 12, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests for the v2 import sidebar link (#2266).
apps/cloud/src/auth/v2-import.test.ts: the eligibility decision. It covers eligible, unverified email, multiple members, someone else as the only member, paid plans, unavailable reads and the order of reads. It also covers the paid-plan predicate and the import URL.e2e/cloud/v2-import-link.test.ts: the real endpoint and the sidebar for a free sole member, the admin and member of a shared org, and a paid sole member. Unverified email has no e2e because the WorkOS emulator verifies every user's email.AutumnServiceagainst a stubbedfetch: onlycustomers.getis called, a 404customer_not_foundis free, free plans and an expired paid plan are free, a paid plan is not, and network errors, non-200 answers, a 404 without that code and malformed bodies all hide the link.@executor-js/emulate0.14.3-mfa.0) has nocustomers.get, so a bun patch adds the route as upstream emulate has it (f05d023, unreleased). Drop the patch when the emulator is bumped past it.