Repository navigation
Validate completed symbolic inputs during search - #620
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed symbolic inputs were replayed only after search ended. A time-limited search could therefore return dozens of inputs that no longer fit the remaining native validation budget.
When capture is enabled, validate each newly captured passing input during search and reuse the existing same-phase replay cache for guidance and final collection. Search and native replay share the existing deadline; the per-operation replay does not subtract the validation reserve a second time. Inputs predicted to fail remain on the original canonical-confirmation path before final collection. Unknown results, conflicting predictions, source checks and incomplete-input accounting remain explicit. The previous public search signature is preserved.
Validation: 33 focused tests (UsvmPropertySearcherTest and SymbolicInputReplayTest), strict main/test Detekt in both modules, and diff checks. Tests cover the final operation crossing the search cutoff, cache reuse, unknown receipts, conflicting predictions, disabled capture and original fault confirmation. The initial Detekt method-length finding was corrected and the final source was checked again.
Based on #615. This is a native-validation fix; real-code readiness will be checked separately on a fresh assembled build. No comparative performance claim is made.