Repository navigation
[PBT] Exclude pure static empty caches from class statement coverage - #601
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class instrumenter rejected an ordinary static empty cache even though the replay contract explicitly excludes module loading from the class statement denominator. Admit only a named static
[]allocation with no constructor-property or same-name static-member collision. Its module-loading allocation gets no statement ID; all existing constructor, instance initializer, and reachable method operations retain their original AST IDs and counters. Other static initializers, static blocks, effects, computed members, generators, and unchecked callable reachability keep their existing boundaries.Validation: all 240 Node adapter tests and all 4 native class replay helper tests pass. The new counter regression fails on the parent instrumenter and passes after restoring this change. It checks that module loading produces no hits, repeated native cache state stays identical, and every constructor/method statement is still credited. Negative tests preserve effectful/spread/nonempty initializers, static blocks, built-in constructor properties, and accessor collisions.
git diff --checkpasses.All 13 unchanged real-class native smoke scenarios were replayed successfully, including both PGOrbit scenarios. The full instrumented PGOrbit preparation still stops explicitly at
CLASS_UNIVERSE_UNSUPPORTED:Unchecked free helper calls cannot establish the selected private callable statement universe. The original source and helper hashes match the frozen manifest. That guard was not relaxed, so this PR establishes the narrow empty-cache measurement contract and does not yet add a fully supported real experiment scenario. Native original replay is not instrumented whole-class replay proof.Depends on #599.