Repository navigation
[JVM] Saturate FP casts at rounded integral upper bounds - #598
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java floating-point casts at a rounded integral upper bound currently enter an out-of-range SMT
fp.to_sbvconversion. Its result cannot be evaluated in the cached model, so a later branch crashes withboth trueModels/falseModels empty. This reproduces in realComplexFormatanalysis through theFraction(double, double, int, int)constructor.Saturate equality to the signed integral maximum before the SMT conversion. Java requires
float -> intat2^31, andfloat/double -> longat2^63, to returnMAX_VALUE. The fork policy is unchanged.Validation: three ordinary Java source regressions reproduce the same fork failure before the fix and all three pass afterward. Each test checks both the boundary and the other input branch. No full test suite was run.