Repository navigation
Preserve erased and instantiated lambda method types - #449
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typed lambda expressions currently exchange the erased SAM signature and the instantiated invocation signature.
RawInstListBuilderstores bootstrap arguments in reverse class-file order, while the typed builder destructures them as forward order. ForPredicate<Integer> p = Character::isWhitespace, the public fields consequently reportIntegeras the erased parameter andObjectas the instantiated parameter. This also prevents correct unboxing followed by widening for aPredicate<Integer>implementation acceptinglong.Read the two method-type arguments in the existing raw order. The raw bootstrap representation and its string-concatenation consumers are unchanged.
Validation: two normal Java-source metadata regressions fail before the fix and pass afterward. All 10 tests in
InvokeDynamicTest, including existing bytecode roundtrip/virtual/constructor cases, pass. No full suite was run.