Repository navigation
chore: turn on typescript noImplicitAny - #3068
Merged
Merged
Conversation
By-name enum lookups go through the new fromStringUnsafe helper, JSON map callbacks are annotated, @types/md5 and @types/lodash.isequal added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Type IPC handler args as the tuples the renderer sends, add declarations for the decompress plugins and @types/semver (required by electron-updater's typings). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name-indexed config setters in the reducer cast explicitly, since they are dynamic by design. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yargs 18 has no typings and @types/yargs 17 adds ~50 unrelated errors, so it gets an explicit any declaration. The remaining pre-existing type errors are untouched; the scripts run via ts-node transpileOnly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It was dropped in be3e116 (2017), which let calls through implicit `any` (e.g. `obj[stringKey](...)`) go unchecked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uhk-web bundles uhk-common, which imports md5 from create-md5-hash.ts. md5 was only reachable transitively through the file:../uhk-common dependency, and uhk-web's lockfile contained no resolved node_modules/md5 entry, so a clean install could leave it out and the dev server failed with: Failed to resolve import "md5" from ".angular/vite-root/uhk-web/main.js" Declare md5 explicitly (pinned to the version uhk-common uses) so the web build always resolves it.
This reverts commit e386849.
ert78gb
approved these changes
Oct 27, 2026
ert78gb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3066 .
Enables strict type-checking that allowed non-type-checked function calls in certain contexts.
fromStringUnsafeso the types remain readable and so that compiler accepts them without errors. (Otherwise, cryptic types would have to be present on the cast site.)This does need a review from someone more typescript-literate than I am.