Repository navigation
fix(buckets): find files in exists_file when fullPath has no leading slash - #1958
Draft
JasperSelmanUiPath wants to merge 1 commit into
Draft
JasperSelmanUiPath wants to merge 1 commit into
JasperSelmanUiPath wants to merge 1 commit into
Conversation
github-actions
Bot
added
test:uipath-langchain
…slash exists_file and exists_file_async added a leading "/" to blob_file_path and compared it exactly with the fullPath that ListFiles returns. Orchestrator returns fullPath without a leading "/", so the paths never matched and both methods always returned False. Compare both paths without the leading "/". Fixes #1957 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JasperSelmanUiPath
force-pushed
the
fix/buckets-exists-file-leading-slash
branch
from
October 28, 2026 09:39
d1f14ab to
ceb16e5
Compare
🚨 Heads up:
|
🚨 Heads up:
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1957 · AGVSOL-9364
What broke:
exists_fileandexists_file_asyncalways returnedFalse, even for a file that is in the bucket. Both methods add a leading/toblob_file_pathand compare the result exactly with thefullPaththatListFilesreturns. Orchestrator returnsfullPathwithout a leading/, so the two never match.The fix: compare both paths without the leading
/.exists_filenow returnsTruewhether or notblob_file_pathstarts with/. TheListFilesprefix query is unchanged, becauseListFilesfinds the file with either prefix.Tests: the
exists_filetests mockedfullPathwith a leading/, which is why they passed while the method was broken. They now mock it without one, as Orchestrator returns it. The found-cases (sync and async) also run with ablob_file_paththat starts with/. Before the fix, 7 of these tests fail; after it, all 1893uipath-platformtests pass.Not changed, for the owners to decide: the
list_filesandget_filestests intest_buckets_service.pyalso mockfullPathwith a leading/(for example"/data/file1.txt"), which is not what Orchestrator returns. Those methods passfullPaththrough without comparing it, so the tests still pass, but the fixtures don't match the real API. I left them as they are. Should they be changed to match?Bumps
uipath-platformto 0.2.42.🤖 Generated with Claude Code