Repository navigation
[Content] Turn on web application home cards and nav links once a product has an active document - #147
Merged
Conversation
…n active document The Web Applications and Services cards and nav entries were hard-coded as Coming Soon, so a product's page was unreachable even after one of its documents went active (including in PR previews). They now follow src/docConfig.js: a product links to its page as soon as any of its documents is active.
Review workflowPurpose: content · Classification: code
Next: Administrator: inspect and merge after CI passes Completed stages persist until an administrator restarts them. Replies and resolved threads are not approval requirements. Use This PR has merged. Production deployment follows the main approval process. |
usace-rmc-docs-review
Bot
changed the title
usace-rmc-docs-review
Bot
added
purpose:content
stage:needs-lane
|
@USACE-RMC/docs-admin — classify this PR with |
Collaborator
Author
|
/review classify code - |
usace-rmc-docs-review
Bot
added
stage:ready-to-merge
|
@USACE-RMC/docs-admin — review requirements are satisfied. Inspect the changes, fill document attribution manually, and merge when CI passes. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Web Applications and Services home cards and header nav entries (DST, System Response Library, LST, RRFT) were hard-coded as Coming Soon. That left a product's page unreachable even after one of its documents went active, including in PR previews: the previews for #145 and #146 have no way to reach the System Response Library page.
They now follow
src/docConfig.js. A newhasActiveDocs(category, software)helper turns a product's card and nav link on as soon as any of its documents is active; otherwise the product stays Coming Soon.Production is unchanged by this PR, since no Web Applications and Services document is active on
mainyet.Document scope
doc_location, or-):-Related issue(s)
None.
Validation
DOCS_MODE=prod npm run buildpasses andnpm run test:reviewpasses. CheckedhasActiveDocsagainstmain(all four products off) and against the BEP branch's registry (System Response Library on, the rest off).Review notes
Code-only:
/review classify code -. After it merges,mainwill be merged into #145 and #146 so their previews link through.