Fix exponential_search recursing forever when the item is below the first element - #15384
Open
Darkslayer3324j wants to merge 1 commit into
Open
Darkslayer3324j wants to merge 1 commit into
Darkslayer3324j wants to merge 1 commit into
Conversation
…irst element binary_search_by_recursion used right=-1 as its 'not given' sentinel, but the recursion legitimately reaches right=-1 when the item is smaller than every element, which reset right to len-1 and never terminated. Use None as the sentinel and add doctests for items below and above the range. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
oga35767-eng
approved these changes
Sep 20, 2026
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
exponential_search(andbinary_search_by_recursion) never terminate when the item is smaller than every element:binary_search_by_recursionusesright=-1to mean "not given" (if right < 0: right = len(...) - 1). When the item is below the first element the recursion legitimately reachesright = midpoint - 1 = -1, which is then mistaken for "not given",rightis reset to the last index, and the search starts over forever. The fix makes the sentinelNone, which cannot collide with a real index. Nothing else in the repository calls this function.Doctests for an item below and above the range are added. I also compared both functions with a membership check on 30,000 random sorted lists (lengths 0-15, values -8..8): 0 mismatches after the change.
Checklist
I left "all my own work" unticked on purpose: this change was written with AI assistance (Claude Code, as
AGENTS.mdinvites). I found the problem by fuzzing the functions insearches/against a membership check, reproduced it, and ran the doctests,ruff checkandruff formaton the changed file.