Repository navigation
Fix PR title bold formatting and null review comments - #74
Merged
Merged
Conversation
A trailing space in a PR title rendered as **foo ** in Teamwork comments, which Markdown doesn't treat as bold, so the asterisks showed up literally. Requires jq 1.7.1+ for trim (Alpine 3.24 ships 1.8.2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bare approvals have a null review body, which jq printed as the string "null" at the end of the Teamwork comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aodhom
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes to the text of the Teamwork comments, one commit each:
**foo **, which Markdown doesn't treat as bold, so the asterisks showed up literally. The title is now trimmed with jq'strim.nullreview body, which was printed as the stringnullunderReview: **approved**. The getter now uses// empty, so nothing is printed.Depends on #73.
trimneeds jq 1.7.1 or later, and the old Alpine 3.11 image ships jq 1.6. This PR targetsbump-alpine-3.24so the diff only shows these two changes. Merge #73 first, and GitHub will retarget this PR tomaster.Testing: I ran both changes on the Alpine 3.24 image in test mode:
" foo \t ") comes back asfoo, and the fixture title is unchanged.nullbody ends atReview: **approved**. The fixture approval (which has a comment) still shows it.Test Task
🤖 Generated with Claude Code