Skip to content

Fix PR title bold formatting and null review comments - #74

Merged
marcizhu merged 3 commits into
masterfrom
fix-comment-formatting
Oct 20, 2026
Merged

marcizhu merged 3 commits into
masterfrom
fix-comment-formatting

Conversation

@marcizhu

Copy link
Copy Markdown
Member

Two small fixes to the text of the Teamwork comments, one commit each:

  • Trim whitespace from PR titles. A title with a trailing space came out as **foo **, which Markdown doesn't treat as bold, so the asterisks showed up literally. The title is now trimmed with jq's trim.
  • Omit the review comment when there isn't one. Bare approvals have a null review body, which was printed as the string null under Review: **approved**. The getter now uses // empty, so nothing is printed.

Depends on #73. trim needs jq 1.7.1 or later, and the old Alpine 3.11 image ships jq 1.6. This PR targets bump-alpine-3.24 so the diff only shows these two changes. Merge #73 first, and GitHub will retarget this PR to master.

Testing: I ran both changes on the Alpine 3.24 image in test mode:

  • A padded title (" foo \t ") comes back as foo, and the fixture title is unchanged.
  • An approval with a null body ends at Review: **approved**. The fixture approval (which has a comment) still shows it.

Test Task

🤖 Generated with Claude Code

marcizhu and others added 2 commits October 20, 2026 18:29
A trailing space in a PR title rendered as **foo ** in Teamwork
comments, which Markdown doesn't treat as bold, so the asterisks showed
up literally. Requires jq 1.7.1+ for trim (Alpine 3.24 ships 1.8.2).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bare approvals have a null review body, which jq printed as the string
"null" at the end of the Teamwork comment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@marcizhu
marcizhu requested a review from a team as a code owner October 20, 2026 16:30
Base automatically changed from bump-alpine-3.24 to master October 20, 2026 16:40
@marcizhu
marcizhu merged commit 3514c60 into master Oct 20, 2026
2 checks passed
@marcizhu
marcizhu deleted the fix-comment-formatting branch October 20, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants