Skip to content

fix: ignore interrupted hero playback - #1378

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/fix-hero-playback-abort
Oct 15, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
taren/fix-hero-playback-abort

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Pausing the homepage video before its play request completes rejects that request with AbortError. The current catch logs it as a playback failure and clears the ready state. Ignore that expected interruption while keeping other playback errors visible.

Replaces the outdated route-level patch in #1214 with the fix in the current HeroPalmMedia component.

Verified with the actual component in a local browser fixture: delayed the MP4 by 30 seconds, paused before it arrived, then restarted. Playback reached readyState 4 with the video visible and no errors. Invalid media still logged NotSupportedError and left the video hidden with the Play button. Full pnpm test passed.

Summary by CodeRabbit

  • Bug Fixes
    • Prevented interrupted video playback from triggering error logs or resetting playback state. Other playback errors continue to be handled as before.

@changeset-bot

changeset-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 066a9f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8550bbf7-f051-4572-b25b-94d7050d23f0
📥 Commits

Reviewing files that changed from the base of the PR and between 1ec8b82 and 066a9f0.

📒 Files selected for processing: 1
  • src/components/home/HeroPalmMedia.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The video playback rejection handler now ignores AbortError rejections. Other playback errors continue through the existing logging and state reset behavior.

Changes: Video playback error handling

Layer / File(s) Summary
Playback rejection handling
src/components/home/HeroPalmMedia.tsx
The handler returns for AbortError rejections. Other errors continue to be logged and reset playback and readiness state.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 066a9

The change ignores expected playback interruptions while retaining existing handling for other playback errors. No merge-blocking risk is apparent.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: ignoring expected interruptions during hero video playback.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 066a9f0 Oct 15 2026, 05:48 AM

@tannerlinsley
tannerlinsley merged commit 86bee61 into main Oct 15, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the taren/fix-hero-playback-abort branch October 15, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant