You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pausing the homepage video before its play request completes rejects that request with AbortError. The current catch logs it as a playback failure and clears the ready state. Ignore that expected interruption while keeping other playback errors visible.
Replaces the outdated route-level patch in #1214 with the fix in the current HeroPalmMedia component.
Verified with the actual component in a local browser fixture: delayed the MP4 by 30 seconds, paused before it arrived, then restarted. Playback reached readyState 4 with the video visible and no errors. Invalid media still logged NotSupportedError and left the video hidden with the Play button. Full pnpm test passed.
Summary by CodeRabbit
Bug Fixes
Prevented interrupted video playback from triggering error logs or resetting playback state. Other playback errors continue to be handled as before.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 8550bbf7-f051-4572-b25b-94d7050d23f0
📥 Commits
Reviewing files that changed from the base of the PR and between 1ec8b82 and 066a9f0.
📒 Files selected for processing: 1
src/components/home/HeroPalmMedia.tsx
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
The video playback rejection handler now ignores AbortError rejections. Other playback errors continue through the existing logging and state reset behavior.
The change ignores expected playback interruptions while retaining existing handling for other playback errors. No merge-blocking risk is apparent.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: ignoring expected interruptions during hero video playback.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pausing the homepage video before its play request completes rejects that request with AbortError. The current catch logs it as a playback failure and clears the ready state. Ignore that expected interruption while keeping other playback errors visible.
Replaces the outdated route-level patch in #1214 with the fix in the current HeroPalmMedia component.
Verified with the actual component in a local browser fixture: delayed the MP4 by 30 seconds, paused before it arrived, then restarted. Playback reached readyState 4 with the video visible and no errors. Invalid media still logged NotSupportedError and left the video hidden with the Play button. Full pnpm test passed.
Summary by CodeRabbit