Repository navigation
chore(preact-table): Support Preact 11 - #6629
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 68cdb5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (47)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 68cdb5a
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview3 package(s) bumped directly, 0 bumped as dependents. 🟨 Minor bumps
|
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We fixed the test:types failure by giving the act() callback in the unmount test a block body. Preact's act requires a callback returning void | Promise<void>, and () => view.unmount() implicitly returned a boolean, which caused TS2322. With the block body, our code type-checks and the unmount test behaves the same.
Tip
✅ We verified this fix by re-running @tanstack/preact-table:test:types.
diff --git a/packages/preact-table/tests/unit/adapterReactivity.test.tsx b/packages/preact-table/tests/unit/adapterReactivity.test.tsx
index c217cf6d5..de75e84cc 100644
--- a/packages/preact-table/tests/unit/adapterReactivity.test.tsx
+++ b/packages/preact-table/tests/unit/adapterReactivity.test.tsx
@@ -436,7 +436,9 @@ describe('Preact adapter reactivity and lifecycle', () => {
expect(text('Lifecycle selection')).toBe('true')
- act(() => view.unmount())
+ act(() => {
+ view.unmount()
+ })
const rootCallsAfterUnmount = rootStoreSelectorCaptor.mock.calls.length
const isolatedCallsAfterUnmount = isolatedStoreCaptor.mock.calls.length
Or Apply changes locally with:
npx nx-cloud apply-locally ZOVA-NnLb
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
… types Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
KevinVandy
marked this pull request as ready for review
October 10, 2026 03:55
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
preactpeer ranges already allow 11 (>=10). This PR moves development to Preact 11 and fixes what broke. The fixes also pass on Preact 10.preactdev dependency in the Preact packages and examples goes from^10to^11.0.1, so CI now builds and tests against Preact 11. The peer ranges still allow Preact 10.@tanstack/preact-storegoes to^0.13.5, with a patch changeset. 0.13.4 declaredpreact: ^10.0.0, so npm rejected Preact 11 even though this package's own peer range allows it (Preact 11 compatability #6616).pnpm-workspace.yamlexempts 0.13.5 from the 24-hour release-age gate because it was published yesterday.preact-table-devtools:useRefgets an explicitundefinedinitial value. Preact 11 types require one. Includes a patch changeset.preact-tabletest: the unmount test wrapsunmount()inact(() => { ... }). Preact 11 runsuseEffectcleanups after unmount, in the next effect flush, as React 18 does.CSSProperties,AriaAttributesandTargetedKeyboardEventfrompreact. Preact 11 removed them from theJSXnamespace, and both 10 and 11 export them frompreact.<input>wrapper components (IndeterminateCheckbox,DebouncedInput) type their spread props so they fit Preact 11's per-type<input>prop union.🤖 Generated with Claude Code
Summary by CodeRabbit