test(lit-query/createQueryController): read 'queryKey' and 'signal' from the 'queryFn' context to avoid shadowing the 'queryKey' helper by sukvvon · Pull Request #12292 · TanStack/query

sukvvon · 2026-10-23T03:08:24Z

🎯 Changes

In createQueryController.test.ts, five queryFns destructured queryKey from the query function context, which shadowed the queryKey helper imported from @tanstack/query-test-utils (no-shadow).

They now take the context as context and read context.queryKey (and context.signal in the one that also used signal). The tests still read the key from the context.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Updated query tests to verify access to query keys and abort signals through the full context.
- Confirmed existing abort-resolution behavior remains covered.

…rom the 'queryFn' context to avoid shadowing the 'queryKey' helper

changeset-bot · 2026-10-23T03:08:32Z

⚠️ No Changeset found

Latest commit: 069b6a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-23T03:08:48Z

View your CI Pipeline Execution ↗ for commit 069b6a6

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 1s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 03:13:27 UTC

github-actions · 2026-10-23T03:09:15Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-23T03:09:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: test/lit-query-createquerycontroller-use-query-fn-context
File: .coderabbit.yaml
Commit: 069b6a6
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: 5100becf-6d10-4524-9625-bb2622de180f

📥 Commits

Reviewing files that changed from the base of the PR and between 2de1d1e and 069b6a6.

📒 Files selected for processing: 1

packages/lit-query/src/__tests__/createQueryController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Several createQueryController tests now access queryKey and signal through the full query context argument. The abort-signal test retains its existing once-only listener and resolution behavior.

Changes: Lit query context test updates

Layer / File(s)	Summary
Use query context in test callbacks `packages/lit-query/src/__tests__/createQueryController.test.ts`	Updated test callbacks to read query-key values from `context.queryKey`. The abort-signal test now registers its listener through `context.signal` and retains the existing resolution behavior.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: chughgaurav

Merge Risk: ⚪ Minimal · up to 069b6

No concrete merge-blocking risk is evident from these test-only changes.

Pre-merge checks: 5

Check name	Status	Explanation
Description check		The description includes all required template sections. It explains the change and motivation, completes the checklist, reports testing, and identifies the change as dev-only with no release impact.
Title check		The title clearly identifies the test file, the context-based access change, and the reason for the change: avoiding shadowing of the queryKey helper.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-23T03:10:37Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12292

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12292

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12292

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12292

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12292

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12292

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12292

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12292

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12292

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12292

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12292

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12292

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12292

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12292

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12292

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12292

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12292

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12292

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12292

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12292

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12292

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12292

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12292

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12292

commit: 069b6a6

github-actions · 2026-10-23T03:10:46Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

test(lit-query/createQueryController): read 'queryKey' and 'signal' f…

069b6a6

…rom the 'queryFn' context to avoid shadowing the 'queryKey' helper

sukvvon self-assigned this Oct 23, 2026

sukvvon merged commit 16f7d4c into main Oct 23, 2026
9 checks passed

sukvvon deleted the test/lit-query-createquerycontroller-use-query-fn-context branch October 23, 2026 03:21

Navigation Menu

Repository navigation

test(lit-query/createQueryController): read 'queryKey' and 'signal' from the 'queryFn' context to avoid shadowing the 'queryKey' helper - #12292

test(lit-query/createQueryController): read 'queryKey' and 'signal' from the 'queryFn' context to avoid shadowing the 'queryKey' helper#12292
sukvvon merged 1 commit into
mainfrom
test/lit-query-createquerycontroller-use-query-fn-context

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 23, 2026

Uh oh!

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 23, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading