refactor(lit-query/createQueriesController): rename the per-result 'observer' in 'trackResult' to 'resultObserver' to avoid shadowing by sukvvon · Pull Request #12291 · TanStack/query

sukvvon · 2026-10-23T01:59:39Z

🎯 Changes

In QueriesController#trackResult, rename the observer picked for each result (observers[index]) from observer to resultObserver.

The observers.forEach((observer) => ...) callback inside trackResult was shadowing it (no-shadow). The callback keeps the observer name, matching getCurrentObserverResults in the same file.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Refactor
- Clarified internal observer naming without changing query result behavior.

…bserver' in 'trackResult' to 'resultObserver' to avoid shadowing

changeset-bot · 2026-10-23T01:59:44Z

⚠️ No Changeset found

Latest commit: be291b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-23T02:00:06Z

View your CI Pipeline Execution ↗ for commit be291b6

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 37s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 02:04:18 UTC

github-actions · 2026-10-23T02:00:35Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-23T02:01:14Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: refactor/lit-query-createqueriescontroller-rename-result-observer
File: .coderabbit.yaml
Commit: be291b6
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: cf7ef9b2-7a9b-4573-b93f-547714e69758

📥 Commits

Reviewing files that changed from the base of the PR and between 2de1d1e and be291b6.

📒 Files selected for processing: 1

packages/lit-query/src/createQueriesController.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

trackResult now names each mapped query observer resultObserver. The existing checks and property-tracking behavior remain unchanged.

Changes: Query result tracking

Layer / File(s)	Summary
Rename per-result observer `packages/lit-query/src/createQueriesController.ts`	The mapped query observer variable is now named `resultObserver`. The missing-observer check, `notifyOnChangeProps` check, and property tracking remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Refactor

Suggested reviewers: chughgaurav

Merge Risk: ⚪ Minimal · up to be291

The PR only clarifies a local variable name and is ready to merge.

Pre-merge checks: 5

Check name	Status	Explanation
Description check		The description includes all required template sections. It clearly explains the rename, its motivation, test status, AI policy acknowledgment, and no-release impact.
Title check		The title clearly and accurately describes the main change: renaming the per-result observer variable to avoid shadowing.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-23T02:01:48Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12291

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12291

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12291

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12291

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12291

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12291

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12291

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12291

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12291

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12291

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12291

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12291

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12291

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12291

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12291

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12291

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12291

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12291

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12291

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12291

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12291

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12291

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12291

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12291

commit: be291b6

github-actions · 2026-10-23T02:01:58Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

refactor(lit-query/createQueriesController): rename the per-result 'o…

be291b6

…bserver' in 'trackResult' to 'resultObserver' to avoid shadowing

sukvvon self-assigned this Oct 23, 2026

sukvvon merged commit 1117bdd into main Oct 23, 2026
9 checks passed

sukvvon deleted the refactor/lit-query-createqueriescontroller-rename-result-observer branch October 23, 2026 03:22

Navigation Menu

Repository navigation

refactor(lit-query/createQueriesController): rename the per-result 'observer' in 'trackResult' to 'resultObserver' to avoid shadowing - #12291

refactor(lit-query/createQueriesController): rename the per-result 'observer' in 'trackResult' to 'resultObserver' to avoid shadowing#12291
sukvvon merged 1 commit into
mainfrom
refactor/lit-query-createqueriescontroller-rename-result-observer

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 23, 2026

Uh oh!

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 23, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading