Skip to content

docs(preact-query/utils): pin the preact and React 'useSyncExternalStore' source links to the copied commits - #12288

Merged
sukvvon merged 1 commit into
mainfrom
docs/preact-query-utils-pin-source-links
Oct 23, 2026
Merged

sukvvon merged 1 commit into
mainfrom
docs/preact-query-utils-pin-source-links

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 23, 2026

Copy link
Copy Markdown
Member

🎯 Changes

Pin the source links in the useSyncExternalStore comment of packages/preact-query/src/utils.ts to commit permalinks, since the main links no longer point at the referenced code:

  • preact: compat/src/hooks.js#L8-L54 now points to 9903119ede99e949d4c146eb42935ee0008caf7f, the revision whose useSyncExternalStore and didSnapshotChange match the copied code. On main, the implementation has since moved to compat/src/render.js.
  • React: useSyncExternalStoreShimClient.js#L84 now points to 9cdf8a99edcfd94d7420835ea663edca04237527, the last revision where line 84 is const [{inst}, forceUpdate] = useState(...). On main, that line has shifted.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@sukvvon sukvvon self-assigned this Oct 23, 2026
@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4d2ab36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sukvvon
sukvvon merged commit 67a8784 into main Oct 23, 2026
7 of 8 checks passed
@nx-cloud

nx-cloud Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 4d2ab36

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 01:05:17 UTC

@sukvvon
sukvvon deleted the docs/preact-query-utils-pin-source-links branch October 23, 2026 01:00
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.76 KB (0%)
react minimal 8.59 KB (0%)

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 0064fe8 and 4d2ab36.

📒 Files selected for processing: 1
  • packages/preact-query/src/utils.ts
+---------------------------------------------------------------------------------------------------------------------------------------+
| Test your estimates. Mathematical analysis of algorithms doesn't tell you everything. Try timing your code in its target environment. |
+---------------------------------------------------------------------------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant