chore(oxlint.config): remove the 'vitest/no-standalone-expect' override left over from the removed 'itIf' helper by sukvvon · Pull Request #12284 · TanStack/query

sukvvon · 2026-10-22T11:12:05Z

🎯 Changes

Remove the vitest/no-standalone-expect override from oxlint.config.ts. Its only purpose was the additionalTestBlockFunctions: ['itIf'] option, and no test uses an itIf helper anymore. The rule itself stays enabled as 'error' through ...pluginVitest.configs.recommended.rules.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated test linting rules: conditional test blocks no longer receive a special exemption for standalone assertions. Existing tests that rely on this exemption may now be flagged by linting. This change affects development checks only; it does not alter app features or behavior.

…de left over from the removed 'itIf' helper

changeset-bot · 2026-10-22T11:12:10Z

⚠️ No Changeset found

Latest commit: 2d5d781

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-22T11:12:31Z

View your CI Pipeline Execution ↗ for commit 2d5d781

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 47s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	26s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-22 11:18:58 UTC

github-actions · 2026-10-22T11:12:55Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-22T11:13:32Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: chore/oxlint-config-remove-no-standalone-expect-override
File: .coderabbit.yaml
Commit: 2d5d781
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: deee7640-4ca1-4478-81d9-56108af2792b

📥 Commits

Reviewing files that changed from the base of the PR and between 84332de and 2d5d781.

📒 Files selected for processing: 1

oxlint.config.ts

💤 Files with no reviewable changes: 1

oxlint.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The test-file override no longer configures vitest/no-standalone-expect with itIf as an additional test-block function.

Changes: Test lint configuration

Layer / File(s)	Summary
Remove test rule override `oxlint.config.ts`	The test override no longer sets `itIf` as an additional test-block function for `vitest/no-standalone-expect`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2d5d7

The obsolete lint exception can be removed without affecting current tests. The change is ready to merge after normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and accurately describes the removal of the obsolete oxlint override related to the removed itIf helper.
Description check		The description includes all required sections, explains the change and motivation, completes the checklist, and identifies the change as development-only with no release impact.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-22T11:14:04Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12284

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12284

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12284

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12284

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12284

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12284

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12284

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12284

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12284

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12284

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12284

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12284

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12284

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12284

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12284

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12284

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12284

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12284

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12284

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12284

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12284

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12284

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12284

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12284

commit: 2d5d781

github-actions · 2026-10-22T11:14:42Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

chore(oxlint.config): remove the 'vitest/no-standalone-expect' overri…

2d5d781

…de left over from the removed 'itIf' helper

sukvvon self-assigned this Oct 22, 2026

sukvvon merged commit 75e64b5 into main Oct 22, 2026
9 checks passed

sukvvon deleted the chore/oxlint-config-remove-no-standalone-expect-override branch October 22, 2026 11:19

Navigation Menu

Repository navigation

chore(oxlint.config): remove the 'vitest/no-standalone-expect' override left over from the removed 'itIf' helper - #12284

chore(oxlint.config): remove the 'vitest/no-standalone-expect' override left over from the removed 'itIf' helper#12284
sukvvon merged 1 commit into
mainfrom
chore/oxlint-config-remove-no-standalone-expect-override

sukvvon commented Oct 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 22, 2026

Uh oh!

nx-cloud Bot commented Oct 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 22, 2026

Uh oh!

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 22, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 22, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 22, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 22, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 22, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 22, 2026 •

edited

Loading

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading