docs(solid-query): add summaries to reference pages that render without a description - #11554
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: TanStack/query/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe PR adds Solid query and mutation behavior descriptions to source documentation and reference pages. It also updates ChangesSolid API documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 05e720d
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview1 package(s) bumped directly, 24 bumped as dependents. 🟩 Patch bumps
|
size-limit report 📦
|
35ea0b4 to
38fdef8
Compare
38fdef8 to
05e720d
Compare
🎯 Changes
useQueryanduseMutationdocument every parameter and carry an@example, but their JSDoc opened with a tag (@seeand@paramrespectively), so TypeDoc had no summary to render and both reference pages started straight at a heading.Each gained one leading sentence; the existing tags are untouched:
useMutationreuses the sentence already shared by the React, Preact and Vue adapters, with "hook" written as "function" — the Solid docs rewrite that word viareplace: { 'hook': 'function' }, so the adapter doesn't call these hooks.useQuerygets a sentence written for this adapter. The other adapters have no shared summary to match here: their documented overload only states theinitialDatacondition, and Vue and Angular describe their own reactivity on top of it.The
initialDataoverload ofuseQueryalready had a summary and is unchanged.Generated docs
pnpm run generate-docsupdates 4 pages from these 2 source changes:functions/useQuery.mdandfunctions/useMutation.md, plusvariables/createQuery.mdandvariables/createMutation.md— thecreateXaliases inherit the JSDoc of the function they alias, so they pick up the summary too. The 3 deleted lines areDefined in:line-number shifts.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit
enabled: falseon initial fetching.