Skip to content

chore(.github/CODEOWNERS): scope 'tanstack-core' ownership to infra paths - #421

Merged
sukvvon merged 1 commit into
mainfrom
chore/align-codeowners
Oct 16, 2026
Merged

sukvvon merged 1 commit into
mainfrom
chore/align-codeowners

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

Replace the catch-all * @TanStack/tanstack-core rule in .github/CODEOWNERS with path-specific rules for .github/, .nx/, nx.json, .changeset/config.json, scripts/ and .npmrc.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Limited the core team’s ownership assignments to selected repository configuration and tooling areas.

@sukvvon
sukvvon requested a review from a team as a code owner October 16, 2026 01:06
@sukvvon sukvvon self-assigned this Oct 16, 2026
@changeset-bot

changeset-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 550a14c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 07e509a2-5a9e-4754-b3cb-dbdfc1962f92
📥 Commits

Reviewing files that changed from the base of the PR and between 3f08b37 and 550a14c.

📒 Files selected for processing: 1
  • .github/CODEOWNERS

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The CODEOWNERS file replaces a rule assigning all files to the TanStack core team with rules for selected paths: .github/, .nx/, nx.json, .changeset/config.json, scripts/, and .npmrc.

Changes: Ownership rules

Layer / File(s) Summary
Scope team ownership
.github/CODEOWNERS
The TanStack core team’s ownership now applies to .github/, .nx/, nx.json, .changeset/config.json, scripts/, and .npmrc instead of all files.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: crutchcorn

Merge Risk: ⚪ Minimal · up to 550a1

The ownership rules are scoped to the selected repository paths, with no supported merge-blocking impact identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description explains the CODEOWNERS change, includes the required checklist sections, and identifies the change as dev-only with no release impact. The unchecked local test item is a minor omissio…
Title check Passed The title clearly and concisely identifies the CODEOWNERS change and the new scoped ownership for infrastructure paths.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 550a14c

Command Status Duration Result
nx affected --targets=test:sherif,test:docs,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-16 01:07:19 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

1 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/typedoc-config 0.3.4 → 0.3.5 Changeset

@pkg-pr-new

pkg-pr-new Bot commented Oct 16, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@tanstack/eslint-config@421
npm i https://pkg.pr.new/@tanstack/publish-config@421
npm i https://pkg.pr.new/@tanstack/typedoc-config@421
npm i https://pkg.pr.new/@tanstack/vite-config@421

commit: 550a14c

@sukvvon
sukvvon merged commit acd9396 into main Oct 16, 2026
10 checks passed
@sukvvon
sukvvon deleted the chore/align-codeowners branch October 16, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants