Repository navigation
fix(ssh): every tunnel strips the client certificate, so mutual TLS never works through one - #3198
Merged
Merged
Conversation
… without Markdown backticks
… the connect uses
…s tunnel behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostandportdirectly, where SSH and Tunnel Command already readtunnelForwardEndpoint.passwordMissingreason with its own message.Label(String),Text(verbatim:), result sheets). The unlocalized "SSH username not set" message also became a localizedSSHTunnelError.usernameMissingcase.tunnelForwardEndpoint.Tests
DatabaseManagerTunnelTests:tcpForwardKeepsClientIdentityandtcpForwardRelaxesVerificationAndKeepsClientIdentityfail without the fix;socketForwardClearsClientIdentityguards the Unix-socket branch.SOCKSProxyTargetTests:hostListConnectionDialsFirstListedNodereads the CONNECT request a fake SOCKS5 server receives and fails without the fix (it dialedstale.example:6379);singleHostConnectionDialsHostAndPortguards the single-host case.BuildAuthenticatorTests:passwordWithoutCredentialThrowsnow expectspasswordMissing(a deliberate spec change) andmissingPasswordIsNotReportedAsRejectedis new; neither compiles without the fix.AuthFailureReasonTestscovers the new case's message throughallCases.CloudflareModelTests.binaryNotFoundIsPlainText,CloudSQLProxyModelTests.binaryNotFoundIsPlainText,SSHConfigTokensTests.expansionFailuresArePlainText,SSHTunnelErrorTests.remoteCommandFailedIsPlainText,NativeDumpRegistryTests.installHintsArePlainTextandPostgreSQLDumpToolCompatibilityTests.refusalsArePlainTextfail without the fix.CloudflareTunnelPaneViewModelTestsandCloudSQLProxyPaneViewModelTests(binaryNotFoundMessageIsPlainText) andSSHTunnelErrorTests.usernameMissingDescriptiondo not compile without it.TunnelCommandPreviewTests:clearedPortPreviewsDefaultPortandhostListPreviewsFirstListedNodefail without the fix ({port}:0andlocalhost:0).NetworkPaneTunnelHostListCaptionTests: the Sentinel (two nodes and one node), Cluster, single Cluster seed and Kafka cases fail without the fix; the MongoDB and no-caption cases guard the existing behavior.swiftlint lint --strictover the 32 changed Swift files reports 0 violations.Docs
The docs rewrite branch covers the user-facing text these changes affect: the tunneled TLS paragraph in
docs/connections/ssl.mdx, the SOCKS host-list note, the new missing-password message, the Tunnel Command preview step and the Redis tunnel host-list wording.