fix(tabs): give version history tabs a symbol in the recent tabs list - #3093
Merged
Merged
Conversation
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maindoes not compile since #3076 and #3061 both landed:MainSplitViewController+RecentTabs.swift:184: error: switch must be exhaustive. #3061 added a switch over everyTabTypeto pick each tab's symbol in the Control-Tab recent tabs list, and #3076 addedTabType.versionHistory. Each compiled on its own branch.Fix
A version history tab shows
clock.arrow.circlepath, the symbol the version history views already use.Tests
No new test: the compiler enforces the switch. A local build of
mainplus this commit was stopped partway for low memory before reaching a verdict, so CI is the build of record here. The same stack minus this line failed only on this error.No CHANGELOG entry: both features are unreleased.