Skip to content

Editor-Syntax #161

Description

@keith-hall

Hi,

I believe that the Editor-Syntax repository has had a few bug fixes upstream since it was copied for use in this repo. Would it make sense to have it as a git submodule, to make it easier to see which version is currently being used by this package, and easier to update this package to use the latest version?

Activity

  1. vors commented on Jul 28, 2018

    @vors
    Member

    ST package manager currently uses master for install. Can it work with submodules? If so, we should do that.

  2. keith-hall commented on Jul 28, 2018

    @keith-hall
    MemberAuthor

    Good question - Package Control just uses GitHub's zip download feature, so I guess it depends whether submodules are included in the zip or not. I will try to investigate this, thanks.

  3. vors commented on Jul 28, 2018

    @vors
    Member

    Thank you, Keith, for taking a look at it. I was too lazy to investigate it properly. If it turns out that it doesn't, we can include a file with a commit sha and a script to auto-update it, something like that.

  4. keith-hall commented on Jul 29, 2018

    @keith-hall
    MemberAuthor

    I have tested, and GitHub doesn't include submodules in the zip file. Your auto update script idea sounds like a good one.

  5. michaelblyons commented on Mar 26, 2019

    @michaelblyons
    Collaborator

    Could you (hard|soft|sym)link to the file that lives in the submodule such that GitHub adds it to the zip? And make a script to convert the file (if Git thinks the link is a file) into a link to be run after clone?

  6. vors commented on Apr 21, 2019

    @vors
    Member

    Not sure is it possible or not. Currently there is no submodule because I don't know how sublime packages with submodules work.

  7. michaelblyons commented on Dec 21, 2024

    @michaelblyons
    Collaborator

    Obsoleted by #165?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions