Repository navigation
Conversation
Contributor
|
Automated Message: This message has been sent to all open pull requests. Your pull request will be further reviewed once Millennium 3.0.0 is released. We are very busy with Millennium! |
Member
|
tested and working as intended |
Member
|
tested update and is working good for review and release |
1) Added the ability to reset settings, as well as export and import them 2) A game ID field has been added so that you can directly open game pages on sites like SteamDB 3) Added the ability to disable specific buttons — instead of removing them 4) Settings are now saved automatically
ricewind012
requested changes
Oct 14, 2026
Member
There was a problem hiding this comment.
I only skimmed through the code, but in general it looks very fragile...
- 253(!) typescript errors, not sure if ci errors on that tho
- useless logs in backend, like comparing millennium version
- useless language option, prefer steam settings
- most dependencies are useless
- @steambrew/client has a sleep export
- huge text size on .millennium-custom-buttons, set to 12px
- useless "title" attribute usage, on .millennium-custom-buttons especially
- useless "top buttons style" settings section, millennium has quickcss
- huge as fuck settings content, but: plain html elements are in use; icons as text, prefer IconsModule; use the description prop for instead of the "title" attribute
# Conflicts: # .gitmodules
Contributor
|
This pull request was closed because the plugin failed to build. See the build log for details. Fix the issue and reopen this pull request to retry the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a few changes: