Repository navigation
Refactor how network tables and prediction is defined - #227
Merged
Merged
Conversation
|
With Rubat tiptoeing around network changes between updates the expected rate of test data adjustment is less than once a year. |
marchc1
approved these changes
Oct 23, 2026
marchc1
left a comment
Member
There was a problem hiding this comment.
Something unexpected was that I expected these changes to decrease the line counts significantly, but its really only ~500 lines removed. It is a lot cleaner though. I fear it may be a bit confusing when porting entity code, but we're pretty close to being done with that on the networking side of things, so I can justify this refactoring now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't like how that worked, we dont need NetworkName and NetworkVar together, NetworkVar now implies its named. There are a couple corrections I spotted by dumping the prediction tables from the binary and fixed them here as well. I think this is a lot nicer than what it was before, this also makes weapons actually work and correctly predict now and everything else that was broken because it lacked the NetworkVar attribute.
Also this comes with a test finally that validates the CRC32 against the server send tables, so that guards against anything accidentally breaking it, the downside is that whenever GMod changes them we have to adjust the test data but I think that is a small price to pay for guarding correctness.