Skip to content

Implement more rendering gaps and some fixes - #160

Merged
marchc1 merged 58 commits into
SourceDotNET:mainfrom
ZehMatt:rendering-holes
Oct 11, 2026
Merged

marchc1 merged 58 commits into
SourceDotNET:mainfrom
ZehMatt:rendering-holes

Conversation

@ZehMatt

@ZehMatt ZehMatt commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@callumok2004

Copy link
Copy Markdown
Member

screenspace_general should probably be taken from the shaders branch, which also contains the changes gmod has made to it

https://github.com/SourceDotNET/Source.NET/blob/c84a44694742c4efc381cb8db6be69074f3b6119/Source.StdShader.Gl46/Screenspace_General.cs

@ZehMatt

ZehMatt commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

screenspace_general should probably be taken from the shaders branch, which also contains the changes gmod has made to it

https://github.com/SourceDotNET/Source.NET/blob/c84a44694742c4efc381cb8db6be69074f3b6119/Source.StdShader.Gl46/Screenspace_General.cs

It would be good in the future to avoid writing branches on this repo and use a fork with draft PRs if its incremental work, so its easier to avoid clashes like this.

@marchc1

marchc1 commented Oct 11, 2026

Copy link
Copy Markdown
Member

Looks good, I have also fixed the merge conflicts from Callum's screenspace_generic. His also didn't account for alphatests which was breaking HDR. Also, the tonemap controller EHANDLE was readonly

@marchc1
marchc1 merged commit 377dd6a into SourceDotNET:main Oct 11, 2026
4 checks passed
@ZehMatt
ZehMatt deleted the rendering-holes branch October 11, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants