Repository navigation
Networkvars - #136
Merged
Merged
Networkvars#136
Conversation
cvttss2si should be (int) cast since I believe the JIT compiles down to that anyway
Need to check the IL output in linqpad, but I believe this would allow the compiler to devirtualize the ILuaObject calls
ZehMatt
reviewed
Oct 7, 2026
Member
Author
|
As far as the string issues and the LINQ issues, I can resolve those in a bit. May have to do some other checks on strings too. Perhaps also @RaphaelIT7 would be interested in doing a quick passover on this NW1/NW2 reimplementation since he documented a lot of it. |
Instead store node order in a separate list for iteration
ZehMatt
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.