Skip to content

DO NOT MERGE - TEST PVF #6312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rombirli wants to merge 2 commits into from
Closed

DO NOT MERGE - TEST PVF #6312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2771253
Make rule S2094 raise on every class
rombirli Oct 8, 2026
d756385
Make rule S2094 raise on every class - FIX
rombirli Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions java-checks/src/main/java/org/sonar/java/checks/EmptyClassCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ public List<Tree.Kind> nodesToVisit() {
public void visitNode(Tree tree) {
ClassTree classTree = (ClassTree) tree;
IdentifierTree simpleName = classTree.simpleName();
if (simpleName != null && isNotExtending(classTree) && isEmpty(classTree)) {
reportIssue(simpleName, "Remove this empty class, write its code or make it an \"interface\".");
}
if (simpleName!=null)
reportIssue(simpleName, "Remove this empty class, write its code or make it an \"interface\".");
Comment on lines +39 to +40

@gitar-bot gitar-bot Bot Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Bug: S2094 now reports every named class/record, not just empty ones

The isNotExtending(classTree) && isEmpty(classTree) guard was removed. Now visitNode calls reportIssue for every CLASS and RECORD that has a name, so you'll get a false positive on every class with members, annotations, record components, a superclass or interfaces. The message "Remove this empty class..." is wrong for all of those. Existing expectations in EmptyClassCheck tests (the // Noncompliant markers on compliant classes) will fail, and analysis results across all projects will flood. To fix this, put the original condition back.

Restore the emptiness/non-extending guard:

if (simpleName != null && isNotExtending(classTree) && isEmpty(classTree)) {
  reportIssue(simpleName, "Remove this empty class, write its code or make it an "interface".");
}

Was this helpful? React with 👍 / 👎

}

private static boolean isNotExtending(ClassTree tree) {
Expand Down
Loading