Skip to content

Use one-based positions in theme check JSON output #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 2 commits into from
Oct 23, 2026
Merged

Use one-based positions in theme check JSON output #8972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
721cf51
Use one-based positions in theme check JSON output
gonzaloriestra Oct 21, 2026
c8dafc4
Consolidate theme check release notes into one changeset
gonzaloriestra Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/cli/json-output.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Progress and diagnostics use JSON side events on stderr.
| Shared meanings | Use `name`, `clientId`, `previousVersion`, and distinct `planHandle`/`planName`. Resource URL names and placement agree across commands. Different projections may expose different fields, but a shared field keeps its meaning. |
| Numbers and enums | Bulk `objectCount` is a nonnegative decimal string; reject unsafe numeric inputs. Bounded counts and positions are nonnegative integers; money uses strings. CLI-owned enums are closed, with kebab-case multiword values. Upstream enums remain extensible strings with documented known values. |
| Files | Use absolute native filesystem paths: `path` for the primary artifact, `directory` for a project directory, descriptive `...Path` fields for additional files. Relative route names stay route names. |
| Diagnostics | Use `filePath` for filesystem paths and array-valued `fieldPath` for configuration fields. JSON line/column positions are zero-based; text presenters can convert them. |
| Diagnostics | Use `filePath` for filesystem paths and array-valued `fieldPath` for configuration fields. JSON line/column positions are one-based, matching human-readable output. |
| Pagination | Use `pageInfo` when results are capped, retain totals already fetched, and distinguish unknown values from `false` or zero. Do not invent a cursor. Document whether the list is complete or one page. |
| Versioning | Version CLI result contracts with the CLI release. Independently versioned artifact formats keep their own versions; do not introduce a command-specific result version field. |

Expand Down
16 changes: 8 additions & 8 deletions packages/cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14151,23 +14151,23 @@ DESCRIPTION
},
"startRow": {
"type": "integer",
"minimum": 0,
"description": "The zero-based starting line."
"exclusiveMinimum": 0,
"description": "The one-based starting line."
},
"startColumn": {
"type": "integer",
"minimum": 0,
"description": "The zero-based starting column."
"exclusiveMinimum": 0,
"description": "The one-based starting column."
},
"endRow": {
"type": "integer",
"minimum": 0,
"description": "The zero-based ending line."
"exclusiveMinimum": 0,
"description": "The one-based ending line."
},
"endColumn": {
"type": "integer",
"minimum": 0,
"description": "The zero-based ending column."
"exclusiveMinimum": 0,
"description": "The one-based ending column."
},
"message": {
"type": "string"
Expand Down
Loading
Loading