Repository navigation
Conversation
The record result's JSON codec and presenter will live in security-record/, beside its schema, as for clean. The text output doesn't change.
`--json` prints the recorded agent-findings.json, its results directory, the app it belongs to, and the number of checks and findings recorded. Without a findings document on stdin, the command aborts with the `findings-document-missing` code. A rejected document aborts with `findings-document-rejected` and lists every error in `details.errors`, so callers can fix them all without parsing the message.
jek
added this pull request to stack #8969
October 21, 2026 00:00
app security record
jek
marked this pull request as ready for review
October 21, 2026 13:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Coding agents pipe their findings document into
app security record. When the document is rejected, they have to read the errors from a terminal box before they can fix them and try again.WHAT is this pull request doing?
Adds
--jsontoapp security record:{"status": "success", "app": {"directory": "/path/to/app", "configurationPath": "/path/to/app/shopify.app.toml", "clientId": "1234"}, "resultsDirectory": "/path/to/app/.shopify/app-security/shopify.app", "path": "/path/to/app/.shopify/app-security/shopify.app/agent-findings.json", "checkCount": 2, "findingCount": 1}findings-document-missing.findings-document-rejected, anddetails.errorslists every error. A document is rejected when it isn't valid JSON, is too large, or fails validation. As before, nothing is written.The first commit moves the terminal presenter to
security-record/result.tswithout changing behaviour.How to manually test your changes?
Build once and run the local CLI directly, so nothing else reaches stdout:
For an accepted document, copy the example from step 4 of
shopify-dev app security instructions --path <app>and pipe it the same way.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add