Repository navigation
Add typed JSON output to theme init - #8923
Open
gonzaloriestra wants to merge 6 commits into
Open
gonzaloriestra wants to merge 6 commits into
gonzaloriestra wants to merge 6 commits into
Conversation
gonzaloriestra
added this pull request to stack #8925
October 15, 2026 12:34
gonzaloriestra
marked this pull request as ready for review
October 15, 2026 12:42
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 15, 2026 13:52
2c94340 to
c6f7d8c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 15, 2026 14:10
c6f7d8c to
15a63a9
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 15, 2026 15:11
f1fefea to
f91b248
Compare
isaacroldan
approved these changes
Oct 15, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 15, 2026 16:13
f91b248 to
f16a877
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 16, 2026 08:15
f16a877 to
78f9f4b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 16, 2026 08:40
78f9f4b to
86a886e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 16, 2026 11:08
54a8ff7 to
5a6e98f
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 16, 2026 11:32
397c2d4 to
f9b20e4
Compare
karreiro
approved these changes
Oct 16, 2026
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @gonzaloriestra!
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 16, 2026 14:20
f9b20e4 to
2241655
Compare
Contributor
|
| Changeset | Package |
|---|---|
theme-check-json-contract.md |
'@shopify/cli': major |
theme-preview-json-contract.md |
'@shopify/cli': major |
theme-profile-environments.md |
'@shopify/cli': major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -21,6 +21,7 @@ declare abstract class BaseCommand extends Command {
static descriptionWithoutMarkdown(): string | undefined;
static analyticsNameOverride(): string | undefined;
static analyticsStopCommand(): string | undefined;
+ private jsonOutputFromFlags;
catch(error: Error & {
skipOclifErrorHandling: boolean;
}): Promise<void>;
@@ -36,6 +37,7 @@ declare abstract class BaseCommand extends Command {
}, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options?: Input<TFlags, TGlobalFlags, TArgs>, argv?: string[]): Promise<ParserOutput<TFlags, TGlobalFlags, TArgs> & {
argv: string[];
}>;
+ protected runWithParsedOutput<T>(flags: FlagOutput, execute: () => T): T;
protected environmentsFilename(): string | undefined;
protected parseEnvironmentFlags<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(environment: JsonMap, options: Input<TFlags, TGlobalFlags, TArgs>, explicitFlags: FlagOutput): Promise<FlagOutput>;
protected validateNonTTYFlags(flags: FlagOutput): void;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR and review history: #8684.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/23694
Theme initialization needs structured outcomes that retain completed setup.
WHAT is this pull request doing?
Return an absolute project directory, instruction file paths and explicit success/partial outcomes. Keep a successfully cloned project when later AI setup fails, exit nonzero for partial work, and reject missing noninteractive names.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add