Repository navigation
Add typed JSON output to theme package - #8922
Merged
gonzaloriestra merged 5 commits intoOct 19, 2026
Merged
Conversation
gonzaloriestra
added this pull request to stack #8925
October 15, 2026 12:34
gonzaloriestra
marked this pull request as ready for review
October 15, 2026 12:42
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 15, 2026 13:33
844e899 to
c193fc0
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
2 times, most recently
from
October 15, 2026 14:10
9cf7b1e to
b737087
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 15, 2026 14:33
b737087 to
419b25d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 15, 2026 15:11
419b25d to
3c93b2a
Compare
isaacroldan
approved these changes
Oct 15, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 15, 2026 16:13
3c93b2a to
d4a4e0e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
2 times, most recently
from
October 16, 2026 08:40
db67891 to
aa183c3
Compare
isaacroldan
reviewed
Oct 16, 2026
isaacroldan
left a comment
Contributor
There was a problem hiding this comment.
The archive receipt issue remains in this replacement PR.
🤖 Generated by the review-pr skill
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
2 times, most recently
from
October 16, 2026 11:08
60c00b5 to
7c167b1
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 16, 2026 11:15
7c167b1 to
bfc5360
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 16, 2026 11:32
bfc5360 to
532fe33
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 16, 2026 14:20
532fe33 to
fc51512
Compare
karreiro
approved these changes
Oct 16, 2026
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @gonzaloriestra!
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 19, 2026 08:44
fc51512 to
9bdfce1
Compare
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Oct 19, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 19, 2026 11:02
9bdfce1 to
decbb12
Compare
Contributor
|
| Changeset | Package |
|---|---|
theme-check-json-contract.md |
'@shopify/cli': major |
theme-profile-environments.md |
'@shopify/cli': major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -21,6 +21,7 @@ declare abstract class BaseCommand extends Command {
static descriptionWithoutMarkdown(): string | undefined;
static analyticsNameOverride(): string | undefined;
static analyticsStopCommand(): string | undefined;
+ private jsonOutputFromFlags;
catch(error: Error & {
skipOclifErrorHandling: boolean;
}): Promise<void>;
@@ -36,6 +37,7 @@ declare abstract class BaseCommand extends Command {
}, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options?: Input<TFlags, TGlobalFlags, TArgs>, argv?: string[]): Promise<ParserOutput<TFlags, TGlobalFlags, TArgs> & {
argv: string[];
}>;
+ protected runWithParsedOutput<T>(flags: FlagOutput, execute: () => T): T;
protected environmentsFilename(): string | undefined;
protected parseEnvironmentFlags<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(environment: JsonMap, options: Input<TFlags, TGlobalFlags, TArgs>, explicitFlags: FlagOutput): Promise<FlagOutput>;
protected validateNonTTYFlags(flags: FlagOutput): void;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR and review history: #8683.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/23694
Packaging needs a machine-readable artifact receipt.
WHAT is this pull request doing?
Return a strict JSON artifact result with a validated absolute path to the ZIP actually written, while preserving the text presenter.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
shopify theme package --path . --json shopify theme package --json-schemaChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add