Repository navigation
Port app security flag descriptions from the shopify.dev docs - #8853
Merged
Merged
Conversation
github-actions
Bot
added
shopify.dev preview
Area: @shopify/cli
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The source descriptions, test assertion, changeset, and generated documentation are consistent.
0 open findings
What changed in this PR
Clarifies App Security flag help text and keeps generated CLI and Shopify.dev documentation synchronized.
Changes:
- Documents
--blockinglevels and default behavior. - Clarifies when to use
--skip-instructions. - Updates tests, generated artifacts, and patch changesets.
| File | Description |
|---|---|
packages/app/src/cli/commands/app/security/blocking-flag.ts |
Updates shared --blocking help. |
packages/app/src/cli/commands/app/security/check.ts |
Updates --skip-instructions help. |
packages/app/src/cli/commands/app/security/check.test.ts |
Updates the description assertion. |
packages/cli/oclif.manifest.json |
Regenerates command metadata. |
packages/cli/README.md |
Regenerates CLI reference text. |
docs-shopify.dev/generated/generated_docs_data_v2.json |
Regenerates Shopify.dev command data. |
.changeset/app-security-flag-descriptions.md |
Adds patch release entries. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmerand
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The shopify.dev docs change for
shopify app security(World PR 2090077) hand-edits two flag descriptions in its copy ofgenerated_docs_data_v2.json. The next docs generation from this repo would overwrite those edits, so the source needs to say the same thing.WHAT is this pull request doing?
Ports those two descriptions to the flag definitions and regenerates the manifest, README and shopify.dev docs data:
--blocking(app security checkandreview): lists the levels and thenonedefault.--skip-instructions(app security check): says when to use it.After regeneration, the five
appsecurity*entries indocs-shopify.dev/generated/generated_docs_data_v2.jsonmatch the World PR's copy exactly. The World PR's other JSON changes are\uescaping and a trailing newline, with no content difference, so there's nothing to port for them.How to manually test your changes?
Check the
--blockingand--skip-instructionsdescriptions.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add