Repository navigation
[AgentX] MiniMax-M3.1-Flash B300 SGLang: add TP2 and TP4 points / [AgentX] MiniMax-M3.1-Flash B300 SGLang:新增 TP2 和 TP4 点 - #4726
Conversation
|
Thanks for the contribution!
中文感谢你的贡献!
|
| # Shortest-prefill-first with a decode interval of 32 on TP4 with DRAM KV offload, | ||
| # filling the curve between the TP2 and TP4 points. |
There was a problem hiding this comment.
🟡 nit (optional): The new override header breaks the AGENTS.md comments rule. Its first sentence restates the override's own flags, and "filling the curve between the TP2 and TP4 points" gives a benchmarking motive, not a technical reason. Fix: delete both lines and keep only the technical comment "2x CONC (AgentX subagent fan-out); the decode graph batch matches it." above zip_override_tp4_dram_spf_interval32.
Why this was flagged
AGENTS.md:56 says "No header comments describing a file, topology, config, recipe, override, or section." AGENTS.md:58 allows only technical explanation and says "never restate the code". The new header at agentic-tp4-spf-extra.yaml:53-54 repeats the args just below it (shortest-prefill-first, prefill-decode-interval: 32, tensor-parallel-size: 4, KV_OFFLOADING: dram). It then adds a sweep-plan note about where these points sit on the curve. agentic-tp4-spf.yaml has the same first sentence, but that file is not part of this change and does not make the rule optional. Leaving this in brings a new rule violation into the repo. It does not affect runtime behavior.
Verification: In agentic-tp4-spf-extra.yaml, lines 53-54 sit above zip_override_tp4_dram_spf_interval32. The first line repeats the override's own args. The second line says where the points sit in the sweep plan. It gives no technical reason for any value. AGENTS.md:56 says "No header comments describing a file, topology, config, recipe, override, or section." Nothing breaks at runtime.
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=41607669507 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=41607669507 |
…sglang-fill-points # Conflicts: # inferencex-e2e/perf-changelog.yaml
|
[by Claude Code] The SGLang cookbook integration of this PR's AgentX config ( This PR has no authorized |
…sglang-fill-points # Conflicts: # inferencex-e2e/perf-changelog.yaml
|
[by Claude Code] sgl-project/sglang#47929 has been merged. This PR's AgentX config ( This PR has no authorized |
…sglang-fill-points # Conflicts: # inferencex-e2e/perf-changelog.yaml
…sglang-fill-points # Conflicts: # inferencex-e2e/perf-changelog.yaml
|
/use 41488743791 |
|
@ispobock staged run 41488743791. This run remains available across future |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have, |
❌❌❌ REJECTED ❌❌❌@Oseltamivir this sign-off cannot be accepted. The comment contains only the intro line, with no checklist items, links, additional detail section, or signature. Also, no eval ran on any commit in this PR, and the sign-off links no upstream recipe. ❌ Check 1 (Sweep + evals on in-PR commit): FAIL — No passing sweep/eval was found on any commit in this PR. Every ❌ Check 2 (Evals pass): FAIL — Evals were skipped. No eval job executed on any in-PR commit, so there are no eval results to check for image, accuracy against peers, or coverage of the changed path. ❌ Check 3 (Upstream recipe): FAIL — The sign-off has no additional detail section and links no merged upstream recipe PR or published cookbook page. An upstream PR, sgl-project/sglang#47929, is MERGED (2026-11-03T03:28Z), but it was synced at this PR's ❌ Check 5 (Latest checklist template): FAIL — The sign-off is missing every item of the current PR_REVIEW_CHECKLIST.md template: all 20 checklist items, the additional detail section, and the signature. Only the opening sentence was posted.
Passed and not applicable checks✅ Check 0 (CODEOWNER): PASS — ✅ Check 4 (Reuse command): PASS — ✅ Check 6 (Upstream images): PASS — The image is upstream ✅ Check 7 (Deprecated models/scenarios): PASS — Per MODELS.md, ✅ Check 8 (No architecture hacks): PASS — There are no ✅ Check 9 (Spec-decode chat template): PASS — AgentX replays the traced chat conversations through ✅ Check 10 (No engine patches): PASS — The new recipes have no setup script, patch, or source edit, and no reachable patching. ✅ Check 11 (Golden simulated AL): PASS — The launcher injects ✅ Check 12 (Append-only): PASS — There is one append-only entry. The PR adds only new recipe files and 8 new search-space rows (35 -> 43 points, no removals). Each new row selects only its own new override, and existing recipes are unchanged. ➖ Check 15 (PR description): N/A — The description's claims match the pinned recipes (TP4 HiCache 290 at c20/44/52/60, TP4 c16 without offload, TP2 HiCache 370 at c44, TP2 mem-fraction 0.93 interval 20 at c50/52). ✅ Check 16 (NVIDIA overview): PASS — The NVIDIA overview lists MiniMax-M3.1-Flash with SGLang. ➖ Check 17 (Metrics publication): N/A — These are direct SGLang configs, with no Dynamo TRT-LLM settings. ✅ Check 18 (Recipe/image/sweep consistency): PASS — Every Assessed commit: |
|
Ingest report — ✅ Results ingested into the Ingest workflow · Merge Ingest run · Benchmark source run
benchmarkFiles 8, rawBenchmarkRows 8, coveredByPerJobFiles 0, purgedPoints 0, failedRunRows 0, runStatsNew 0, runStatsDuplicate 0, evalSamplesNew 0, gpuMetricSamplesNew 164952, powerPublicationPoints 8, changelogEntriesWritten 1 Counts cover only this run. Rows: benchmark_results, eval_results, agentic rows linked to a trace, gpu_metrics series. This comment updates if the ingest is rerun. 中文Ingest 报告 — ✅ 结果已写入 上表仅统计本次运行写入的数据,各行单位依次为 benchmark_results 行、eval_results 行、已关联 trace 的 agentic 行和 gpu_metrics 序列。重新运行 ingest 时本评论会原地更新。 |
Add points to the B300 SGLang AgentX curve: