Repository navigation
service: group the alternatives of the __in filter lookup - #321
Closed
VitorCoelho wants to merge 3 commits into
Closed
VitorCoelho wants to merge 3 commits into
VitorCoelho wants to merge 3 commits into
Conversation
Added tests for counting employees with chainable filters.
Document fixes related to filter lookup and entity updates.
phanak-sap
self-requested a review
October 25, 2026 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
__inlookup of the chainable filter produced its alternatives without parentheses. Lookups are joined withand, andandbinds tighter thanor, so combining__inwith any other lookup changed the meaning of the filter:Why
The query returned entities that do not match the other lookups. This is the
__inbreakage mentioned in the discussion of #280. Only the output of__initself is grouped, so other filters keep their current URLs, and__inwith a single value is still a plainID eq 1.How it was tested
test_count_with_chainable_filter_in_operator_and_other_lookup: fails onmaster, passes with the fix.test_count_with_chainable_filter_in_operatornow expects(ID eq 1 or ID eq 2 or ID eq 3), which has the same meaning.pytest: 300 passed.