Skip to content

Fix Windows C playtest SDK deprecation errors - #47

Merged
JamieW105 merged 1 commit into
mainfrom
fix/c-playtest-windows-strcpy
Oct 23, 2026
Merged

JamieW105 merged 1 commit into
mainfrom
fix/c-playtest-windows-strcpy

Conversation

@JamieW105

Copy link
Copy Markdown
Collaborator

C playtest validation fails on Windows because the SDK's two strcpy calls trigger CRT deprecation warnings under -Werror. Copy the saved callback source with memcpy and strlen + 1 in both directions, preserving the terminating NUL and existing buffer sizes without suppressing compiler warnings.

Validation:

  • Reproduced both original errors using a GCC deprecation declaration matching the Windows CRT diagnostic.
  • Compiled the fixed C starter with C17, -Wall -Wextra -Werror, and the same deprecation declaration.
  • Exercised repeated live queries with short and near-limit UTF-8 callback snapshots; verified source restoration, snapshot reads, and command flush order.
  • git diff --check passed.

Remaining validation: native Windows playtest and installer build. The required powershell -ExecutionPolicy Bypass -File ./tools/build-windows-installer.ps1 attempt failed because PowerShell is unavailable in this Linux workspace; no installer was produced. Cargo is also unavailable, so Rust tests could not run. Kept as draft pending Windows validation.

@JamieW105 JamieW105 self-assigned this Oct 22, 2026
@JamieW105
JamieW105 marked this pull request as ready for review October 23, 2026 03:51
@JamieW105
JamieW105 merged commit ef3f31b into main Oct 23, 2026
8 checks passed
@github-actions
github-actions Bot deleted the fix/c-playtest-windows-strcpy branch October 23, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants