Repository navigation
Fix Windows C playtest SDK deprecation errors - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C playtest validation fails on Windows because the SDK's two
strcpycalls trigger CRT deprecation warnings under-Werror. Copy the saved callback source withmemcpyandstrlen + 1in both directions, preserving the terminating NUL and existing buffer sizes without suppressing compiler warnings.Validation:
-Wall -Wextra -Werror, and the same deprecation declaration.git diff --checkpassed.Remaining validation: native Windows playtest and installer build. The required
powershell -ExecutionPolicy Bypass -File ./tools/build-windows-installer.ps1attempt failed because PowerShell is unavailable in this Linux workspace; no installer was produced. Cargo is also unavailable, so Rust tests could not run. Kept as draft pending Windows validation.