Skip to content

aes: add inline attributes - #598

Merged
newpavlov merged 2 commits into
RustCrypto:masterfrom
stepantubanov:add-inline-attr
Sep 18, 2026
Merged

newpavlov merged 2 commits into
RustCrypto:masterfrom
stepantubanov:add-inline-attr

Conversation

@stepantubanov

@stepantubanov stepantubanov commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Just a tiny perf fix. Perf was ~1.5-2x worse after updating aes from 0.9.2 to 0.9.3 and turned out it was due to some functions not getting inlined across crate boundaries.

@newpavlov newpavlov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I previously fixed inlining in #575, but the attributes got lost again during refactoring in #580.

Although it's a bit surprising that such tiny functions do not get inlined (probably because of some bad interaction with #[target_feature(enable = "...")]).

@newpavlov
newpavlov merged commit a7136b4 into RustCrypto:master Sep 18, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants