Repository navigation
Conversation
mikeharv
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10437
Proposed Changes
This PR updates
Grid(used byFieldColourthrough its parent classFieldGridDropdown) to focus and select the first item if no item was focused bysetSelectedValue()due to the provided value not being one of the options in the grid dropdown.Arguably,
FieldColourshould have validated that its value was only set to one of the available options, but given that it doesn't, we're kind of stuck with that, as there are likely serialized projects with values for that field that are not in its picker. Given that constraint, falling back to selecting the first option in the grid seems reasonable and avoids a focus trap that could otherwise prevent keyboard navigation.Reason for Changes
Before, keyboard users could encounter a difficult-to-escape focus trap if they edited a
FieldColourwhose value was not in its grid.