Repository navigation
fix: resize flyout on workspace resize; navigate navigable stacks - #10599
Merged
Merged
Conversation
gonfunko
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
This fixes two core bugs related to flyouts, both of which will aid in delivering updates to the
toolbox-searchplugin.The details
Proposed Changes
This is testable in core Blockly by creating a toolbox that ends with a non-navigable separator:
Before the change, attempting to wrap categories fails with a warning in the console. Screenshot below shows the result of pressing down arrow with "Math" category already focused:
With this change, navigation proceeds to the next navigable:
Screen.Recording.2026-10-20.at.3.49.58.PM.mov
This doesn't provide an immediately obvious benefit, however it's necessary to keep a pinned element aligned with the right side of a horizontal flyout. Previously it would stay at its old x position but now it track's the flyout's right edge. These screen captures were recorded on the feat!: update toolbox search UI #10551 branch.
Before:
Screen.Recording.2026-10-20.at.3.53.53.PM.mov
After:
Screen.Recording.2026-10-20.at.3.55.51.PM.mov
Additional Information
Unblocks #10551