Skip to content

fix(netdev): correct ping delay logic for last packet and avoid rt_thread_delay(0) #11866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rbb666 merged 1 commit into from
Oct 15, 2026
Merged

fix(netdev): correct ping delay logic for last packet and avoid rt_thread_delay(0) #11866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions components/net/netdev/src/netdev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,8 +1371,7 @@ int netdev_cmd_ping(char* target_name, char *netdev_name, rt_uint32_t times, rt_
min_time = 0xFFFFFFFF;
for (index = 0; index < times; index++)
{
int delay_tick = 0;
rt_tick_t start_tick = 0;
rt_tick_t start_tick = 0, cost_tick = 0, delay_tick = 0;

rt_memset(&ping_resp, 0x00, sizeof(struct netdev_ping_resp));
start_tick = rt_tick_get();
Expand Down Expand Up @@ -1413,8 +1412,19 @@ int netdev_cmd_ping(char* target_name, char *netdev_name, rt_uint32_t times, rt_
}

/* if the response time is more than NETDEV_PING_DELAY, no need to delay */
delay_tick = ((rt_tick_get() - start_tick) > NETDEV_PING_DELAY) || (index == times) ? 0 : NETDEV_PING_DELAY;
rt_thread_delay(delay_tick);
cost_tick = rt_tick_get() - start_tick;
if (index != times - 1)
{
if (cost_tick < NETDEV_PING_DELAY)
{
delay_tick = NETDEV_PING_DELAY - cost_tick;
}
}

if (delay_tick > 0)
{
rt_thread_delay(delay_tick);
}
}

if (times == 0)
Expand Down
Loading