Repository navigation
fix(sql): the destructive-query detector covers the gaps listed in #1770 - #1786
Merged
Merged
Conversation
…L DELETE forms, WITH ... DELETE, EXPLAIN ANALYZE, DROP COLUMN and other DROPs (#1770)
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1770.
[\p{L}\p{N}_$]+), soDROP TABLE "заказы",DROP DATABASE складandpublic.заказыare detected and named in full.DELETEacceptsLOW_PRIORITY,QUICK,IGNOREand the multi-tableDELETE t1 FROM t1 JOIN ....EXPLAIN ANALYZEand aWITH ... (...)list are looked through before matching DELETE / UPDATE. A plainEXPLAINstill does not count.dropColumn(HIGH) forALTER TABLE ... DROP COLUMNanddropOther(MEDIUM) for DROP INDEX / TYPE / FUNCTION / PROCEDURE / ROLE / USER and similar.Not covered: a data-modifying CTE body (
WITH d AS (DELETE ... RETURNING *) SELECT ...). Tests not run locally, CI will.