Repository navigation
Validate complete typed IPC values and release 0.52.3 - #76
Merged
Merged
Conversation
|
|
||
| def accept(self, request: _Request) -> int: | ||
| """Return the accepted request value.""" | ||
| ... |
|
|
||
| def retrieve(self) -> _Request: | ||
| """Return a typed record.""" | ||
| ... |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typed RPC parameters previously decoded only the first batch of their embedded Arrow IPC value. That silently accepted extra batches/trailing bytes and bypassed subclasses'
deserialize_from_bytesvalidation, including VGI's raw payload-size bound.Route typed parameters and unary results through the existing byte-codec hook. The default decoder requires one complete batch followed by physical EOF or a valid legacy/modern EOS; its existing empty/schema-only utility behavior is preserved. Normalize malformed in-memory IPC errors so HTTP requests return 400 and corrupt unary results retain the client's TransportError handling. Streaming RPC framing is unchanged.
Prepare v0.52.3. This is a decoder correction; it adds no wire fields or protocol capabilities.
Validation on Linux ARM64 EC2:
ty check vgi_rpc/, pydoclint, lock consistency, and wheel/sdist build passed.ty checkreports 232 diagnostics, also reproduced at unchanged base f616b98; the library scope used by CI passes.