Skip to content

Use auto-activate instead of the deprecated auto-activate-base - #648

Open
mmcky wants to merge 1 commit into
mainfrom
claude/funny-hamilton-3j8jve
Open

mmcky wants to merge 1 commit into
mainfrom
claude/funny-hamilton-3j8jve

Conversation

@mmcky

@mmcky mmcky commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

With conda-incubator/setup-miniconda@v4, every job that sets up conda logs this warning:

auto-activate-base is deprecated. Please use auto-activate. If your installer does not use the base environment as the default environment, also add activate-environment: base.

This renames the input in ci.yml, cache.yml and publish.yml. The value stays true. The execution-*.yml workflows don't set it, so they are unchanged.

The second half of the warning doesn't apply. The Miniconda installer's default environment is base, and each job still activates the quantecon environment through activate-environment.

Workflows are not synced to the translation repos, so each edition gets the same change in its own PR:

🤖 Generated with Claude Code

https://claude.ai/code/session_01Wyb6EzbNzY5a8uuJPnDtUb


Generated by Claude Code

setup-miniconda v4 warns on every run:

  `auto-activate-base` is deprecated. Please use `auto-activate`.

Rename the input in ci.yml, cache.yml and publish.yml. The value stays
true, and the installer's default environment is base, so the second
half of the warning (add `activate-environment: base`) does not apply;
each job still activates the quantecon environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wyb6EzbNzY5a8uuJPnDtUb
Copilot AI balanced review requested due to automatic review settings October 13, 2026 05:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

It is a minimal, consistent rename of a deprecated input to its documented replacement across all relevant active workflows, with environment activation preserved and no behavioral change.

0 open findings

What changed in this PR

Replaces the deprecated auto-activate-base input with its replacement auto-activate in the conda setup step of the active conda-incubator/setup-miniconda@v4 workflows, silencing the deprecation warning emitted on every job. The value remains true, and each job continues to activate the quantecon environment via activate-environment, so behavior is preserved. This is a CI maintenance change coordinated across the translation editions in separate PRs.

Changes:

  • Rename auto-activate-base: true → auto-activate: true in ci.yml, cache.yml, and publish.yml.
  • execution-*.yml left unchanged because they never set this input; _github_actions/ci.yml (on @v2, in an ignored subdirectory) is out of scope.
File Description
.github/​workflows/​ci.yml Renames deprecated auto-activate-base input to auto-activate in the miniconda setup step
.github/​workflows/​cache.yml Same deprecated-input rename in the cache workflow's miniconda setup
.github/​workflows/​publish.yml Same deprecated-input rename in the publish workflow's miniconda setup

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants