Skip to content

Use auto-activate instead of the deprecated auto-activate-base - #98

Open
mmcky wants to merge 1 commit into
mainfrom
claude/funny-hamilton-3j8jve
Open

mmcky wants to merge 1 commit into
mainfrom
claude/funny-hamilton-3j8jve

Conversation

@mmcky

@mmcky mmcky commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

With conda-incubator/setup-miniconda@v4, every job that sets up conda logs this warning:

auto-activate-base is deprecated. Please use auto-activate. If your installer does not use the base environment as the default environment, also add activate-environment: base.

This renames the input in ci.yml, cache.yml and publish.yml. The value stays true.

The second half of the warning doesn't apply. The Miniconda installer's default environment is base, and each job still activates the quantecon environment through activate-environment.

This is the same change as QuantEcon/lecture-python-programming.zh-cn#109, whose build ran without the warning, and the matching PR in QuantEcon/lecture-python-programming.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Wyb6EzbNzY5a8uuJPnDtUb


Generated by Claude Code

setup-miniconda v4 warns on every run:

  `auto-activate-base` is deprecated. Please use `auto-activate`.

Rename the input in ci.yml, cache.yml and publish.yml. The value stays
true, and the installer's default environment is base, so the second
half of the warning (add `activate-environment: base`) does not apply;
each job still activates the quantecon environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wyb6EzbNzY5a8uuJPnDtUb
Copilot AI balanced review requested due to automatic review settings October 13, 2026 05:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The rename matches the valid auto-activate input in the action's verified action.yml, is applied consistently across all three workflows, and preserves existing behavior.

0 open findings

What changed in this PR

This PR silences a deprecation warning emitted by conda-incubator/setup-miniconda@v4 by renaming the auto-activate-base input to auto-activate across the repository's GitHub Actions workflows. The value is kept as true, preserving existing behavior. I confirmed against the action's action.yml (at both refs/tags/v4 and main) that auto-activate is a valid input defaulting to "true", and that auto-activate-base is explicitly marked "(deprecated in favor of auto-activate)". Each job still sets activate-environment: quantecon, so the warning's secondary condition does not apply, and no stale auto-activate-base references remain.

Changes:

  • Renamed auto-activate-base: true to auto-activate: true in three workflow files.
  • Behavior preserved (value remains true; activate-environment: quantecon unchanged).
File Description
.github/​workflows/​ci.yml Uses the non-deprecated auto-activate input in the CI conda setup.
.github/​workflows/​cache.yml Uses the non-deprecated auto-activate input in the cache conda setup.
.github/​workflows/​publish.yml Uses the non-deprecated auto-activate input in the publish conda setup.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants