Repository navigation
configgen: remove dead input_exit_emulator_btn write - #7
Merged
Merged
Conversation
…nfig Live-tested with this removed on ODROID-M1: Hotkey+Start still exits a running libretro core fine. hotkeygen synthesizes a keyboard Shift+Esc for the retroarch context's 'exit' action, and RetroArch's own default config already binds input_exit_emulator="escape" to that. This per-controller joypad binding was never the actual path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S6emcPYtMgjwcmPBmUt74u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out this was dead code. Live-tested with it removed: Hotkey+Start still quits a running libretro core fine on ODROID-M1.
The actual mechanism is
hotkeygen, which synthesizes a keyboardShift+Escfor the retroarch context'sexitaction, and RetroArch's own default config already bindsinput_exit_emulator="escape"to that. This per-controllerinput_exit_emulator_btnbinding was never the real path, it was redundant from the start.Removing it to keep the tree clean before the next upstream sync.