Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic SWT depth in
mra2andmranincludes dimensions that are not being transformed. An RGB image transformed over its spatial axes therefore gets depth zero from its three-channel dimension and raises during reconstruction:Before this change both calls raise a dimension-mismatch error. A two-channel input instead silently selects one level where its spatial dimensions support four.
Infer the default depth from the selected axes.
mranalready has their sizes;mra2uses the existing axis-validation helper. Clarify the default-level documentation and remove the outdated restriction ofmra2'saxesto DWT. Explicit levels and DWT behavior stay the same.On 72 actual face-image configurations (1/2/3 channels, channel-axis placement, both APIs, db1/db2 and float32/64), 48 errors and 24 shallow decompositions become 72 correct decompositions. Every component matches processing each real channel independently, and all 72 explicit-level controls retain identical arrays.
All 18 new regression cases fail on main and pass with the fix. The full package suite passes (1070 tests, two skips) and project hooks pass. The release 1.10.0 wheel and the actual head of #847 reproduce the same issue; that PR changes MRA annotations only.