Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imra2andimranadd details into the supplied approximation array. Reconstructing twice from the same decomposition therefore adds the details twice, and later filtered reconstructions use a changed approximation:Copy the approximation before summing in both inverse functions. This retains the existing summation order and allocates one output array. It also allows read-only coefficient arrays.
Validation covers actual camera/RGB-face/ECG data with DWT/SWT, both APIs, db2/sym4 and real/complex single/double precision. All 80 configurations change their input before; none do afterward. All 80 first-reconstruction outputs remain byte-identical, repeated outputs now agree exactly, and all read-only cases complete. An independent sum of attenuated components agrees within 4.32e-5 in float32.
All 32 new regressions fail on main and pass with the fix. The full package suite passes (1084 tests, two skips), as do the project pre-commit hooks. The released 1.10.0 wheel and #847's head reproduce the same mutation; #847 changes annotations only in this module.