Repository navigation
CircuitPython builds pygraphics as a user C module only - #43
Merged
Merged
Conversation
…ript and its shared-bindings copy go
This reverts commit 433ca79.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CircuitPython 11 builds user C modules through
USER_C_MODULES, the way MicroPython does, and pygraphics has built that way since #41 (unix, Feather RP2040, Feather M4 Express). The older route,apply_cp_patches.shcopying a shared-bindings version of the module into a CircuitPython 10.x tree and patching its makefiles, goes, with what only it used:apply_cp_patches.sh,circuitpython.mkandsrc/circuitpython_spike/;#if CIRCUITPY && !PYGRAPHICS_USER_C_MODULEbranch ingfx_bindings_mp.c, which skippedMP_REGISTER_MODULEfor that build. The module now registers itself on every build.The README and installation page give the
make ... USER_C_MODULES=command for CircuitPython instead, and drop a link to an aggregator repository that no longer exists.